Attention is currently required from: laforge, tnt.

View Change

4 comments:

• File src/e1d.h:

  • Patch Set #1, Line 199: void *srv;

    Ok, I see it used in further patches, but then I'd use the proper type struct osmo_e1dp_server. […]

    It is required for future patches to refer to the server.

• File src/osmo-e1gen.c:

  • Patch Set #1, Line 440: void osmo_e1dp_server_event(void) {}

    Why do we need this ?

    the server is only available for osmo-e1d binary, not for osmo-e1gen binary. The dummy function just ignores the events for the non-existent protocol server.

• File src/proto_clnt.c:

  • Patch Set #1, Line 72: void (*event_cb)(enum osmo_e1dp_msg_type event, uint8_t intf, uint8_t line, uint8_t ts, uint8_t *data, int len);

    Maybe typedef some type osmo_e1dp_event_cb_t or something ?

    Done

  • Patch Set #1, Line 85: clnt->event_cb(hdr->type, hdr->intf, hdr->line, hdr->ts, msgb_l1(msgb) + sizeof(*hdr), msgb_l1len(msgb) - sizeof(*hdr));

    Shouldn't msgb_l2() work ? And if not, having the l2h set by earlier code would probably be good.

    Done

To view, visit change 35558. To unsubscribe, or for help writing mail filters, visit settings.