Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/25559?usp=email )
Change subject: ns2: trigger a reset in case of receiving a NS STATUS with incompatible protocol state ......................................................................
Patch Set 3:
(1 comment)
File src/gb/gprs_ns2_vc_fsm.c:
https://gerrit.osmocom.org/c/libosmocore/+/25559/comment/936ad6af_2616dbcb?u... : PS3, Line 748: if (fi->state != GPRS_NS2_ST_RESET && fi->state != GPRS_NS2_ST_UNCONFIGURED) {
shouldn't we also move to some "unconfigured" state ourselves to be in sync with the peer after rese […]
I'll mark it as wip again. It depends on the NS mode: - for SNS we might want to do handle it in a different way, because this shouldn't happen in SNS. Maybe try to remove it? Unsure atm. Because it would mean, somehow we managed to get out of sync.
- for IPA style, go to reset - for NS static, go into recovering.
Also it would be great to analyse the underlying message, if available. Because if we received a NS Alive as failure, we can be sure, we have to go to reset, otherwise a BLOCKED NS-VC might be detectable by this.