Attention is currently required from: daniel, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email )
Change subject: osmo_stream_cli_write(): fix double-free of msgb
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS1:
before
PS1:
I guess it may be that we actually want to return at
the end of that 'ret < 0' clause? not sure if r […]
before
I462cb176ebc51f3e99ee796310e8665144c84ccc was introduced by pespin in August 2023, we did
return from the clause (at least in EAGAIN case).
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I954678acd90593e5311d22a10033c7741f280be3
Gerrit-Change-Number: 36159
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2024 10:25:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment