Attention is currently required from: laforge, pespin.
csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )
Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ......................................................................
Patch Set 21:
(4 comments)
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/5e9700b6_910288e5?usp=... : PS21, Line 1828: get_object_identity_string(object_id_state[4]),
wrong indentation
Wrong how? Previously it was said that the indentation has to be moved to the (, and that is what I did.
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/8b27bdbd_9137ad9c?usp=... : PS21, Line 1860: !FIND_ELEM(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state))) {
wrong indentation, indent it so that both "!FIND_ELEM" end up in the same column.
On my end they are exactly like that. At least in Notepad++
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/df9b5616_b9f4ab5d?usp=... : PS21, Line 1876: get_object_identity_string(object_identity[1]),
wrong indentation
Same as on the first one.
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/81374914_e7b1673a?usp=... : PS21, Line 1884: get_object_identity_string(object_identity[1]),
wrong indentation
Same as on the first one.