Attention is currently required from: laforge, pespin.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28131 )
Change subject: stp: Fix sporadic failure in TC_ipa_to_m3ua_ni
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
This looks like a similar issue to what I encountered before. If so the race is most
likely that the f_IPA_send and the second f_vty_config2 have arrived in the same main loop
iteration in the stp and the config change is being handled before the data is forwarded.
So I think that the first sleep is unnecessary and I's simply move the second config
command until after re response is received.
File stp/STP_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28131/comment/ec119eae_b621…
PS1, Line 149: f_vty_config2(VTY, {"cs7 instance 0"}, "network-indicator
international");
I would just move this second config down after line 155 where we received the expected
response.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28131
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3ef08447d2e36b6948d3db4ec9d1459beebc9384
Gerrit-Change-Number: 28131
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 24 May 2022 11:11:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment