21 Jul
2023
21 Jul
'23
2:37 p.m.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33848 )
Change subject: vty: Allow space in network name ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
Not sure if other osmo programs may also need the same patch?
Which programs? What do you mean?
PS2: Oh, we ended up submitting two similar patches yesterday.
File src/libmsc/msc_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33848/comment/a3ace18f_e55d310f PS2, Line 134: .NAME Adding a dot is not enough, you also need to do `argv_concat()`. Done in my patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33848
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie85e98790d6917a30c84333203cbc00c4ceb97e8
Gerrit-Change-Number: 33848
Gerrit-PatchSet: 2
Gerrit-Owner: matanp matan1008@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 21 Jul 2023 12:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment