Attention is currently required from: fixeria, osmith.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/36972?usp=email )
Change subject: esim.es2p: Split generic part of HTTP/REST API from ES2+
......................................................................
Patch Set 4:
(2 comments)
File pySim/esim/es2p.py:
https://gerrit.osmocom.org/c/pysim/+/36972/comment/2c93a8b0_77e054bc
PS4, Line 24: import base64
some imports (like `abc`, `json`, `base64`) are no
longer used in this module
Done
File pySim/esim/http_json_api.py:
https://gerrit.osmocom.org/c/pysim/+/36972/comment/923a7b78_f83f9423
PS4, Line 22: from datetime import datetime
: import time
not really used here
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/36972?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I468041da40a88875e8df15b04d3ad508e06f16f7
Gerrit-Change-Number: 36972
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Jun 2024 11:48:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment