Attention is currently required from: laforge.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email )
Change subject: ccid: properly emit wait time ext messages ......................................................................
Patch Set 3:
(1 comment)
File ccid_common/iso7816_fsm.h:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/838f5a13_8bd... : PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */
In that case either the linter rules need to be changed, or there needs to be a separate patch for a […]
And how is reformatting changed code in a patch preceding the patch changing the code supposed to work? A linter time travel hook that does this by looking at changed lines and emitting a second preceding commit and rebasing, maybe? Is the linter now suddenly holding my patch hostage here, again? No matter what I do I get dragged into code formatting discussions, even if we have a linter, even if we have a .clang-format style used by the linter that is supposed to be used to reformat the code so we finally stop discussing formatting. The so called linting has been a nuisance and massive drag on anything with tons of legacy code and no clear coding style for years with zero discernible benefit and the issues appear to get more contrived every year.