[M] Change in libosmo-pfcp[master]: Port pfcp socket to osmo_iofd

Attention is currently required from: laforge, neels, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/39459?usp=email ) Change subject: Port pfcp socket to osmo_iofd ...................................................................... Patch Set 1: (2 comments) File src/libosmo-pfcp/pfcp_endpoint.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/39459/comment/a78dbc8c_1b1f9f9c… : PS1, Line 492: struct osmo_io_ops ioops `static const`? https://gerrit.osmocom.org/c/libosmo-pfcp/+/39459/comment/58ad4605_53d71fa4… : PS1, Line 517: if (rc < 0) You're checking `rc < 0` twice now, is this second check still needed? -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/39459?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: If85888b6857899e0aca1fdd1d806c53476b4d239 Gerrit-Change-Number: 39459 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 04 Feb 2025 07:47:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No