Attention is currently required from: daniel, fixeria, pespin.
Jenkins Builder has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email )
Change subject: Add test to ensure parsing works
......................................................................
Patch Set 2:
(1 comment)
File tests/parse/tcap_parse_test.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394/comment/1c44c09e_e48c... :
PS2, Line 38: if (rc.code != RC_OK) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0
Gerrit-Change-Number: 41394
Gerrit-PatchSet: 2
Gerrit-Owner: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Tue, 11 Nov 2025 08:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No