Change in osmo-hnbgw[master]: mgw_fsm: add MGW support to osmo-hnbgw

Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 ) Change subject: mgw_fsm: add MGW support to osmo-hnbgw ...................................................................... Patch Set 27: (6 comments) File src/osmo-hnbgw/context_map.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/4e83f824_60411522 PS25, Line 142: /* a possibly still existing MGW FSM must be termiated when the context Done File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/9d9c9c48_5f1916d2 PS25, Line 50: * do not support at the moemnt. */ Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/68537baa_c91c4407 PS25, Line 52: /* Send Iu Release request, this is done in errornous cases from which we cannot recover */ Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/6fb1dfb3_b2659bc3 PS25, Line 53: static void tx_release_req(struct hnbgw_context_map *map) Do you have any ideas where? This is a helper function that is called from to location of this FSM to format an IuRelease message. https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/d4282147_7b3c8b4b PS25, Line 424: rc = msgb_resize_area(mgw_fsm_priv->ranap_rab_ass_resp_oph->msg, In practice the message don't change ths size, but in theory they might either shrink or grow. So what is done here is to resize the area for l2 to have some headroom. Then we encode the message and resize again to the actual message lenght. So yes, this is to make sure that no overflow happens and that the memory in the msgb is accessed in a safe way. https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/2c09115f_a1e8227d PS25, Line 627: static int handle_rab_release(struct hnbgw_context_map *map, struct osmo_prim_hdr *oph, ranap_message *message) It does belong to here. This function is a helper function to interpret the content of the RabRelease that might be encapsulated in the RAB Assignment Request. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4 Gerrit-Change-Number: 26795 Gerrit-PatchSet: 27 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 15:31:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment