Attention is currently required from: laforge, pespin.

View Change

6 comments:

• File src/osmo-hnbgw/context_map.c:

  • Patch Set #25, Line 142: /* a possibly still existing MGW FSM must be termiated when the context

    terminated

    Done

• File src/osmo-hnbgw/mgw_fsm.c:

  • Patch Set #25, Line 50: * do not support at the moemnt. */

    moment

    Done

  • Patch Set #25, Line 52: /* Send Iu Release request, this is done in errornous cases from which we cannot recover */

    Request

    Done

  • Patch Set #25, Line 53: static void tx_release_req(struct hnbgw_context_map *map)

    This function doesn't really look like belonging in this file. […]

    Do you have any ideas where? This is a helper function that is called from to location of this FSM to format an IuRelease message.

  • Patch Set #25, Line 424: rc = msgb_resize_area(mgw_fsm_priv->ranap_rab_ass_resp_oph->msg,

    I'm still not understanding why is this resize here needed. […]

    In practice the message don't change ths size, but in theory they might either shrink or grow. So what is done here is to resize the area for l2 to have some headroom. Then we encode the message and resize again to the actual message lenght. So yes, this is to make sure that no overflow happens and that the memory in the msgb is accessed in a safe way.

  • Patch Set #25, Line 627: static int handle_rab_release(struct hnbgw_context_map *map, struct osmo_prim_hdr *oph, ranap_message *message)

    Same, this function doesn't really look like belonging in this file.

    It does belong to here. This function is a helper function to interpret the content of the RabRelease that might be encapsulated in the RAB Assignment Request.

To view, visit change 26795. To unsubscribe, or for help writing mail filters, visit settings.