[L] Change in libosmocore[master]: core: Add software UART implementation

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation ...................................................................... Patch Set 3: (5 comments) Patchset: PS3: I think something like a soft-uart is an ideal candidate for some unit tests for decoding valid characters, handling parity error, overrun error, ... File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/177dad01_8b5e747a PS3, Line 132: TODO: verify parity not critical to get it merged: But do you still have on your agenda to implement this? https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/187a66db_ad266314 PS3, Line 138: fprintf(stderr, "framing e this was ok for a hack in my private branch, but we shouldn't merge code to master that prints directly to stderr... https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/79e5b6c8_467cd481 PS3, Line 181: if (!suart->tx.running) the transmit is not implemented at all? Please squash your additions/fixes into this patch so we don't merge incomplete code in a commit. https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/ed646dc4_30c0ca5f PS3, Line 203: /* FIXME: Tx */ likewise here. the function is a NOP. Please squash your implementation into the patch, thanks. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 15:07:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment