Attention is currently required from: fixeria, jolly.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email )
Change subject: core: Add software UART implementation ......................................................................
Patch Set 3:
(5 comments)
Patchset:
PS3: I think something like a soft-uart is an ideal candidate for some unit tests for decoding valid characters, handling parity error, overrun error, ...
File src/core/soft_uart.c:
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/177dad01_8b5e747a PS3, Line 132: TODO: verify parity not critical to get it merged: But do you still have on your agenda to implement this?
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/187a66db_ad266314 PS3, Line 138: fprintf(stderr, "framing e this was ok for a hack in my private branch, but we shouldn't merge code to master that prints directly to stderr...
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/79e5b6c8_467cd481 PS3, Line 181: if (!suart->tx.running) the transmit is not implemented at all? Please squash your additions/fixes into this patch so we don't merge incomplete code in a commit.
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/ed646dc4_30c0ca5f PS3, Line 203: /* FIXME: Tx */ likewise here. the function is a NOP. Please squash your implementation into the patch, thanks.