Attention is currently required from: fixeria, jolly.
5 comments:
Patchset:
I think something like a soft-uart is an ideal candidate for some unit tests for decoding valid characters, handling parity error, overrun error, ...
File src/core/soft_uart.c:
Patch Set #3, Line 132: TODO: verify parity
not critical to get it merged: But do you still have on your agenda to implement this?
Patch Set #3, Line 138: fprintf(stderr, "framing e
this was ok for a hack in my private branch, but we shouldn't merge code to master that prints directly to stderr...
Patch Set #3, Line 181: if (!suart->tx.running)
the transmit is not implemented at all? Please squash your additions/fixes into this patch so we don't merge incomplete code in a commit.
Patch Set #3, Line 203: /* FIXME: Tx */
likewise here. the function is a NOP. Please squash your implementation into the patch, thanks.
To view, visit change 30763. To unsubscribe, or for help writing mail filters, visit settings.