Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406 )
Change subject: fix coding of Network Instance IE
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406/comment/a6083bac_3c46af10
PS1, Line 13: These qualify for moving to libosmocore utils
BTW, libosmocore already offers some APN conversion
API:
https://cgit.osmocom. […]
SO IIUC the code that neels proposes here is not
needed since the same is already implemented in libosmocore?
File src/libosmo-pfcp/pfcp_ies_custom.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406/comment/e1f9af35_922dc52e
PS1, Line 86: static int strncpy_buf(char *buf, size_t buflen, const char *src, size_t
len)
len is "srclen"?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I9d67464ef0f92b0512cfd6e48d203f8828a82a19
Gerrit-Change-Number: 30406
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:01:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment