Attention is currently required from: laforge, fixeria.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/30114
)
Change subject: add codec_mapping.h,c
......................................................................
Patch Set 4:
(2 comments)
File src/libmsc/codec_mapping.c:
https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/d7d9f3bd_1e78e937
PS1, Line 8: * SPDX-License-Identifier: GPL-2.0+
AGPL-3. […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/ecafb3bd_3a147881
PS1, Line 29: FIXME: I'm not sure about OFR, OHR -- O means octet-aligned??
in any case, just to be clear: OFR/OHR are not
supported in our stack so far.
just noting some half knowledge i came across;
Related: 3GPP TS 26.103
Mention in 3GPP TS 48.058 9.3.6 Channel Mode
and 3GPP TS 48.008 3.2.2.11 Channel Type
I wasn't aware yet of this relation:
GSM speech full rate version 1: GSM FR.
GSM speech full rate version 2: GSM EFR.
GSM speech full rate version 3: FR AMR.
GSM speech full rate version 4: OFR AMR-WB.
GSM speech full rate version 5: FR AMR-WB.
GSM speech half rate version 1: GSM HR.
GSM speech half rate version 2: not defined in this version of the protocol.
GSM speech half rate version 3: HR AMR.
GSM speech half rate version 4: OHR AMR-WB.
GSM speech half rate version 6: OHR AMR.
interesting how "half rate version 5" is skipped without a mention.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/30114
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Iaa307be6a8487aa8d4ba7cd59d5c5ef04818a744
Gerrit-Change-Number: 30114
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Mar 2023 04:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment