Attention is currently required from: pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/33499
)
Change subject: ASCI: rtp_stream_commit(): Also update MGW on conn mode change
......................................................................
Patch Set 7:
(1 comment)
File src/libmsc/rtp_stream.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33499/comment/996c6bfd_66dfb53a
PS6, Line 441: rtps->mode_sent_to_mgw = false;
imho this should only be set if
"rtps->crcx_conn_mode != mode", aka new mode different than old mode […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/33499
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7a5637d0a7f1df13133e522fc78ba75eeeb2873e
Gerrit-Change-Number: 33499
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Jul 2023 11:25:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment