Attention is currently required from: keith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/29649
)
Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bts-trx/trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29649/comment/d295b109_e6acbeca
PS3, Line 411: if (pinst->trx && pinst->trx->mo.nm_state.operational ==
NM_OPSTATE_ENABLED) {
Actually, from adding some printf locally, I see
checking for pinst->trx was enough to not trigger t […]
That really depends on
the order you use in the config file I think, so better not to rely only on pinst->trx
to fnd out wheter you are at startup.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Comment-Date: Thu, 06 Oct 2022 16:53:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: keith <keith(a)rhizomatica.org>
Gerrit-MessageType: comment