Attention is currently required from: fixeria, laforge.
osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335?usp=email )
Change subject: Revert "clang-format: set ColumnLimit: 0" ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335/comment/bab27f47_138... : PS1, Line 11: Reason for revert: we don't want clang-format to actively generate arbitrarily long line lengths.
According to https://clang.llvm.org/docs/ClangFormatStyleOptions. […]
I see now that this comes from https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/7b053680_9e9.... But still, I think if we don't set this to 0, we run into other problems when it reformats other lines that look like they intentionally were kept shorter. For example:
``` diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c index 0c56275..a3374ae 100644 --- a/ccid_common/ccid_slot_fsm.c +++ b/ccid_common/ccid_slot_fsm.c @@ -66,10 +66,8 @@ struct card_uart *cuart4slot_nr(uint8_t slot_nr) return g_si.slot[slot_nr].cuart; }
-static const uint8_t sysmousim_sjs1_atr[] = { - 0x3B, 0x9F, 0x96, 0x80, 0x1F, 0xC7, 0x80, 0x31, - 0xA0, 0x73, 0xBE, 0x21, 0x13, 0x67, 0x43, 0x20, - 0x07, 0x18, 0x00, 0x00, 0x01, 0xA5 }; +static const uint8_t sysmousim_sjs1_atr[] = { 0x3B, 0x9F, 0x96, 0x80, 0x1F, 0xC7, 0x80, 0x31, 0xA0, 0x73, 0xBE, + 0x21, 0x13, 0x67, 0x43, 0x20, 0x07, 0x18, 0x00, 0x00, 0x01, 0xA5 };
```
...so I propose to adjust the config to not change any line breaks in order to not have it enforce different line breaks than what developers did intentionally (if this can be done with clang-format). I left another comment here: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comments/c54370ae_2e...