[S] Change in osmo-mgw[master]: IuUP: Allow Initialization with set rem IP address and unset rem port

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email ) Change subject: IuUP: Allow Initialization with set rem IP address and unset rem port ...................................................................... Patch Set 4: (4 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/ada45e97_26192709 PS4, Line 838: osmo_sockaddr_port(&conn->end.addr.u.sa) == 0) { We need to keep it this way I submitted, at least for address, since the configured address at this point may be wrong (the hnb may actually be using another IP address, what osmo-mgw was submitted was just a guess, and it cannot be considered confirmed until IuUP Initialization happens). So if IP address is set but port is not, we cannot validate IP address of received packet against the configured one, because it is "a guess", we must accept it anyway, at least to carry on with IuUP initialization. https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/01d4c9a3_be3f7c7e PS4, Line 841: announce that's why I didn't write "not all hNodeb", to leave it undetailed. I can add "some", but since we didn't play with many others I preferred leaving it this way. I think even in the diagrams in specs it shows up this way (IuUP Initialization happening before RAB-Ass-Resp). Do you know of any HNB not doing it this way? https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/d6994204_0c6123e7 PS4, Line 842: ASs Ack https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/238815b4_a883cf2a PS4, Line 843: MDCX Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idd833997abce46886e9664505b2776fa5dadc8db Gerrit-Change-Number: 35176 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 10:37:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment