15 Jul
2025
15 Jul
'25
8:54 p.m.
Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40698?usp=email )
Change subject: mmctx: LOGIUP: allow ue to be NULL ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File include/osmocom/sgsn/mmctx.h:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40698/comment/11e6652f_daa74cd4?usp... : PS1, Line 236: ue->conn_id idea for a separate patch: `(ue)->conn_id`
https://gerrit.osmocom.org/c/osmo-sgsn/+/40698/comment/ebc8f6b0_c2589a6a?usp... : PS1, Line 238: {} I would not print curly braces in the case of `NULL` at all.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40698?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie569fa100abe518cb63c1b918ad7748a7ea3bb99
Gerrit-Change-Number: 40698
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Tue, 15 Jul 2025 18:54:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes