Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/35978?usp=email )
Change subject: VTY: rename 'sctp-role' to 'transport-role', add an alias
......................................................................
Patch Set 2:
(1 comment)
File tests/vty/ss7_asp_test.vty:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35978/comment/1aaab25f_0ac3392f
PS2, Line 425: role sg
: transport-role ser
i think this again illustrates the danger of such changes: user loads an older config file
with sctp-role, re-saves it and it gets translated to transport-role. Now he cannot use
the config file anymore with older software versions for no good reason.
It's a fundamental problem. I'm not saying it must be solved now. Just expressing
my displeasure about it :/
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/35978?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iab6c898181d79a5ed2bea767ee90e55bc3af16a5
Gerrit-Change-Number: 35978
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Feb 2024 12:52:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment