Change in osmo-bsc-nat[master]: bsc_nat_sccp_inst: local_sccp_addr -> addr

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27470 ) Change subject: bsc_nat_sccp_inst: local_sccp_addr -> addr ...................................................................... Patch Set 2: (1 comment) File include/osmocom/bsc_nat/bsc_nat.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27470/comment/bbee2312_1d1a38a2 PS1, Line 28: struct osmo_sccp_addr addr; /* OsmoBSCNAT's local address */ I've used addr in other places too in later patches in this patchset, IMHO it is nicely consistent and short: sccp_inst->addr subscr_conn->bsc->addr subscr_conn->msc->addr Since there is no other address for the sccp_inst it should be clear that it's the local address. Also there's the comment in case it's not clear. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3083374d589487ed960507e7a431c45914afc5dd Gerrit-Change-Number: 27470 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Mar 2022 12:35:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment