Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/29772
)
Change subject: contrib/jenkins.sh: run …rebuild.sh from workspace
......................................................................
Patch Set 1:
(1 comment)
File contrib/jenkins.sh:
https://gerrit.osmocom.org/c/osmo-ci/+/29772/comment/c89a72c1_bac4a927
PS1, Line 7: clone_repo() {
did you think about using pushd+popd?
yes. IMHO
it makes it more complicated since depending if the git repository exists already or not,
we would need to pushd once or twice.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ci/+/29772
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I998c0d47ee5ce6f9978d1a6c9e195d5ce40e4e85
Gerrit-Change-Number: 29772
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Oct 2022 14:01:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment