Attention is currently required from: msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30961 )
Change subject: layer23: Initial VTY framework to share VTY code between apps
......................................................................
Patch Set 8:
(2 comments)
File src/host/layer23/src/common/vty.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/19fc7a41_5e4a514e
PS8, Line 186: int l23_vty_init(int (*config_write_ms_node_cb)(struct vty *))
Would nice to make this void while at it: it always
return 0 which is ignored by the caller anyway.
This may be returning 0 only now but
it's an API so I prefer keeping return int and checking result in case the
implementation changes.
File src/host/layer23/src/modem/vty.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/ea11308f_f6245797
PS8, Line 49: int modem_vty_init(void)
Same here
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30961
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iabfb3129199488d790b89884bc1e424f2aca696f
Gerrit-Change-Number: 30961
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 14 Jan 2023 19:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment