Attention is currently required from: msuraev.

View Change

2 comments:

• File src/host/layer23/src/common/vty.c:

  • Patch Set #8, Line 186: int l23_vty_init(int (*config_write_ms_node_cb)(struct vty *))

    Would nice to make this void while at it: it always return 0 which is ignored by the caller anyway.

    This may be returning 0 only now but it's an API so I prefer keeping return int and checking result in case the implementation changes.

• File src/host/layer23/src/modem/vty.c:

  • Patch Set #8, Line 49: int modem_vty_init(void)

    Same here

    Done

To view, visit change 30961. To unsubscribe, or for help writing mail filters, visit settings.