[M] Change in osmo-hnbgw[master]: tweak lots of logging

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 ) Change subject: tweak lots of logging ...................................................................... Patch Set 4: (2 comments) File src/osmo-hnbgw/hnbgw.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/96cbece1_0acd35c4 PS3, Line 373: result = talloc_asprintf(OTC_SELECT, "%s %s", result, ctx->identity_info); same answer as other patch: IMHO this is the best way. I do not think changing this would have any noticeable impact on performance of osmo-hnbgw. If it turns out to be performance critical, most definitely outputting the log line is much more heavy on load, and the only solution with any noticeable effect is anyway to scale down logging by cranking up category levels. You're of course aware that all of this code is skipped when no target will output the line. Another approach you might suggest would be a 'name' cache added to struct hnb_context, and make sure to keep it updated as hnb_context members change. I would rather avoid that complexity: The current code is guaranteed to never print outdated items. Have you guys thought this through? Am I missing something? File src/osmo-hnbgw/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/1cf17292_fae68e7d PS3, Line 515: LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "using: cs7-%u %s <-> %s %s %s\n", Some context: this is the single "i am ready" notification for one SCCP link to an MSC or SGSN. This is called exactly once per 'msc N' and 'sgsn N' at program startup, at the point where the cn link to the msc or sgsn has resolved the cs7 instance N that it will use, and local and remote point-codes for this CN peer. The function might be called again *only* when the user changes the SCCP configuration via telnet VTY so that SCCP links need to be restarted. This would be a single 'LOG_CNLINK(...)' somewhere, but some scenarios reach this point in a different code path. If you still think it is important to change this code: wdym by 'extra log line'? Do i understand this right: you are saying, it should be a macro to retain the caller's __FILE__ __LINE__ information? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I41275d8c3e272177976a9302795884666c35cd06 Gerrit-Change-Number: 33171 Gerrit-PatchSet: 4 Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 08 Jun 2023 00:22:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: comment