Attention is currently required from: jolly, fixeria, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33448 )
Change subject: ASCI: Add Notification/FACCH support ......................................................................
Patch Set 5: Code-Review+1
(3 comments)
File include/osmo-bts/notification.h:
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/83d8200b_fe60fe77 PS5, Line 60: int facch_gen_msg(struct gsm_bts *bts, uint8_t *out_buf, const uint8_t *group_call_ref, const uint8_t *chan_desc, As far as I understand this is an ASCI related function. Maybe the name should make this clear as well. Like bts_asci_facch_gen_msg() ?
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/f7f3f360_a88f8501 PS5, Line 814: broadcast_facch
AFAIU, this function is broadcasting FACCH on all channels, even if they're not related to VGCS/VBS. […]
Maybe it would be good to add a comment to clarify this?
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/0c3c46bb_0d390762 PS5, Line 814: static int broadcast_facch(struct gsm_bts *bts, const uint8_t *group_call_ref, const uint8_t *chan_desc, maybe rename this asci_broadcast_facch, so that it is more clear that this function is asci related? In rsl.c a lot stuff comes together and since ASCI is a bit special I think it would be good to make everything ASCI related distinguishable from the regular GSM stuff.