Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34490?usp=email )
Change subject: ASCI: Add channel description to messages from MM to RR layer ......................................................................
Patch Set 5:
(2 comments)
File src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/34490/comment/b425430c_24dfd339 PS5, Line 65: struct gsm48_chan_desc ch_desc; did you check all users of this struct to make sure eveyrthing is updated? Is this field always present in all contexts where this struct is used?
File src/host/layer23/src/mobile/gsm48_mm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34490/comment/534f1b8e_c5e20d13 PS5, Line 882: memcpy(&rrh->ch_desc, ch_desc, sizeof(rrh->ch_desc)); you may want to memzero the rrh_ch_desc here if ch_desc=NULL