Attention is currently required from: pespin, msuraev.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/31298 )
Change subject: mobile: add optional statsd support
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/31298/comment/5f9f83e8_8f7c02b2
PS1, Line 7: statsd support
You're not adding any actual stats items, but adding the VTY commands only.
Are you planning to implement them soon? What ticket is this related to?
File src/host/layer23/include/osmocom/bb/common/l23_app.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/31298/comment/d513fb93_b64fdaaa
PS1, Line 17: L23_OPT_STAT
Why making this optional command line option? If some app indicates L23_OPT_VTY, then I
guess it makes sense to install the necessary VTY commands without relying on a separate
flag?
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/31298
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7905b44478dcb9bcf0a1a68fde95f470c07edca3
Gerrit-Change-Number: 31298
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 12 Feb 2023 19:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment