Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

Attention is currently required from: neels, fixeria, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 10: (11 comments) Patchset: PS4: Done File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/74679f07_5ba40524 PS3, Line 3089: "Enable BTS setup ramping to limit the number of BTS which configure within a time window.\n" Done https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/f750c9cb_f9b4f79a PS3, Line 3090: "Limit number of BTS.\n" Done File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/a8319faa_b7c2f525 PS4, Line 86: { 0, NULL }, Done https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/d7ac14f7_5ef653e8 PS4, Line 101: net->bts_setup_ramp.active because it's a single line. If ramp_active() is checking more, i'll use it here too. https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/f6a1bd64_7a9ed357 PS4, Line 107: net->bts_setup_ramp.active same https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/1cf8509e_d30a6021 PS4, Line 164: net->bts_setup_ramp.active same https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/845e595d_c66f67ff PS4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list); Done File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/3e4a01a0_724a3ebe PS1, Line 345: case NM_EV_RAMP_GO: If I do it as you ask, I would have to check in which state the fsm is to prevent the LOGL_ERROR line about an invalid event. Further I don't like to call config_loop() when the MO is already in enabled mode. In theory it could go there if there is a bug in the BTS (e.g. ipaccess). File src/osmo-bsc/nm_bts_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/6c4910ba_1997bfbf PS1, Line 63: if (llist_entry_empty(&bts->bts_ramp.list)) Done https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/9bd50c06_6f7e844e PS1, Line 86: net->bts_ramp.count >= net->bts_ramp.max_bts) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 30 Oct 2022 12:53:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment