Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099 )
Change subject: rlcmac: Initial implementation of UL TBF assignment and scheduler
......................................................................
Patch Set 17:
(8 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099/comment/b8322d4f_be26db3c
PS16, Line 9: er t
("step")
Done
Patchset:
PS16:
in general i wish you wouldn't have a habit of
putting comments in the same line as code... […]
I simply removed the T_def line
since it's not used yet. I was simply adding the T_def there because it's needed
by the fsm change-state functions, and in preparation for follow-up development.
File src/rlcmac/rlcmac.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099/comment/74059d44_ec9501ce
PS16, Line 40: { .T=1, .default_val=1, .unit=OSMO_TDEF_S, .desc="foobar",
.val=0 },
is this a regression test? doesn't look like one.
so probably: […]
Done
File src/rlcmac/tbf_ul_ass_fsm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099/comment/811e1e9b_f1a39d11
PS16, Line 53: [GPRS_RLCMAC_TBF_UL_ASS_ST_COMPL] = { },
All of them are unset. […]
Done
File src/rlcmac/tbf_ul_fsm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099/comment/aaa89194_a5704158
PS16, Line 42: [GPRS_RLCMAC_TBF_UL_ST_FLOW] = { },
(same)
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099/comment/313b6743_77cd46e2
PS16, Line 93: }
drop this func?
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099/comment/89b66a40_528ff43b
PS16, Line 147:
(extra blank line)
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099/comment/0585a2ea_d69bb983
PS16, Line 207:
This is actually needed otherwise linter fails.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I420c57a9d0b63f9c2805a7c2ae8ce85532a48eef
Gerrit-Change-Number: 31099
Gerrit-PatchSet: 17
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Feb 2023 10:04:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment