Attention is currently required from: neels, fixeria.

View Change

8 comments:

• Commit Message:

  • Patch Set #16, Line 9: er t

    ("step")

    Done

• Patchset:

  • Patch Set #16:

    in general i wish you wouldn't have a habit of putting comments in the same line as code... […]

    I simply removed the T_def line since it's not used yet. I was simply adding the T_def there because it's needed by the fsm change-state functions, and in preparation for follow-up development.

• File src/rlcmac/rlcmac.c:

  • Patch Set #16, Line 40: { .T=1, .default_val=1, .unit=OSMO_TDEF_S, .desc="foobar", .val=0 },

    is this a regression test? doesn't look like one. so probably: […]

    Done

• File src/rlcmac/tbf_ul_ass_fsm.c:

  • Patch Set #16, Line 53: [GPRS_RLCMAC_TBF_UL_ASS_ST_COMPL] = { },

    All of them are unset. […]

    Done

• File src/rlcmac/tbf_ul_fsm.c:

  • Patch Set #16, Line 42: [GPRS_RLCMAC_TBF_UL_ST_FLOW] = { },

    (same)

    Done

  • Patch Set #16, Line 93: }

    drop this func?

    Done

  • Patch Set #16, Line 147:

    (extra blank line)

    Done

  • Patch Set #16, Line 207:

    This is actually needed otherwise linter fails.

    Done

To view, visit change 31099. To unsubscribe, or for help writing mail filters, visit settings.