Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34175 )
Change subject: msc/BSC_Conn…: ass req/compl: check/use CSD codec ......................................................................
Patch Set 1:
(1 comment)
File msc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34175/comment/99782f2b_2278f... PS1, Line 1154: {ts_CodecCSData})) {
you could move all this under "if" block in line 1162.
I had this at first, but changed it to 2 ifs so we do the checks first (more checks in 1641 and 1645), and then assign codec and tla. I find this slightly more elegant but don't have a strong preference.