Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32399
to look at the new patch set (#7).
Change subject: Move out of alloc_algo code modifying the data model
......................................................................
Move out of alloc_algo code modifying the data model
This way the alloc_algo() becomes idempotent, simplifying implementation
of new alloc_algos as well as rolling abck if allocation fails (for
instance because some resource is exhausted at the time).
For now the code applying the results is moved to tbf::alloc_algo(), but
it will eventually get out of tbf code, so that the MS object is
responisble for running it. As a result, there's no even need to create
TBF object before trying to allocat resources, which will help furher in
rollback operations described above.
Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20
---
M src/alloc_algo.cpp
M src/alloc_algo.h
M src/gprs_pcu.h
M src/tbf.cpp
M src/tbf.h
M src/tbf_dl.cpp
M src/tbf_dl.h
M src/tbf_ul.cpp
M src/tbf_ul.h
M tests/tbf/TbfTest.err
M tests/ulc/PdchUlcTest.cpp
11 files changed, 390 insertions(+), 375 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/99/32399/7
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32399
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20
Gerrit-Change-Number: 32399
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset