17 Jul
2023
17 Jul
'23
7:47 p.m.
Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33690 )
Change subject: pySim/cards: Split legacy classes away from core SIM + UICC ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/33690/comment/594e5e00_51673824 PS4, Line 319: SimCard
I personally would put a comment into UiccCardBase that describes the situation. […]
I'll add that comment after the current patch series is merged to avoid too much fall-out.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33690
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id36140675def5fc44eedce81fc7b09e0adc527e1
Gerrit-Change-Number: 33690
Gerrit-PatchSet: 5
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 17 Jul 2023 17:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: dexter pmaier@sysmocom.de
Gerrit-MessageType: comment