Attention is currently required from: pespin, fixeria.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/29403 )
Change subject: llc: add struct value_string osmo_gprs_llc_sapi_names[]
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/gprs/llc/llc.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/29403/comment/e5b57f07_cfd95dbd
PS2, Line 22: #define osmo_gprs_llc_sapi_name(val) \
we usually have static inlines for this, it also
becomes clearer regarding the value passed to it.
ack
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/29403
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I8ae048ab9e6b63697951fa3f74ce671c88328f5f
Gerrit-Change-Number: 29403
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Sep 2022 11:42:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment