[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

20 Feb 2025

Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email )

Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2
......................................................................

Patch Set 5:

(32 comments)

File include/osmocom/vlr/vlr.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/243f8a2c_91e584a9?us… :
PS5, Line 121: 	long long unsigned int id;
type 'long long unsigned int' should be specified in [[un]signed]
[short|int|long|long long] order

File src/libvlr/vlr.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/29b3e3a1_ddc77c54?us… :
PS5, Line 238: 		OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" :
"", vsub->msisdn);
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/34786e2b_3ef5d6d6?us… :
PS5, Line 242: 		OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":"
: "", vsub->tmsi);
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/7b552900_0a5b1f18?us… :
PS5, Line 246: 		OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present?
":" : "", vsub->tmsi_new);
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c72fb538_dc962426?us… :
PS5, Line 258: 	char *name = (char*)vlr_subscr_name(vsub);
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/af1eb04c_7f2ac166?us… :
PS5, Line 263: 		strcpy(name + maxlen - 2, "..");
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/a6d51b24_60db80f9?us… :
PS5, Line 380: 		vlr_subscr_name(vsub), (e->count - old_use_count) > 0?
"+" : "-", e->use,
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3af5a618_f78830ad?us… :
PS5, Line 705: 	         osmo_plmn_name(&vsub->sgs.last_eutran_plmn) :
code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d7654f7d_7612867f?us… :
PS5, Line 810: 	struct sgsn_subscriber_pdp_data* pdata;
"foo* bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d9e5c379_a20de30d?us… :
PS5, Line 1447: 						      VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi);
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f2ad7b45_e1290bc7?us… :
PS5, Line 1455: 			return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI,
(void*)mi->imsi);
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/032253ba_2732a45e?us… :
PS5, Line 1457: 			return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI,
(void*)mi->imei);
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/ce18777c_898eb5cb?us… :
PS5, Line 1459: 			return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV,
(void*)mi->imeisv);
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/70628b62_d854c73b?us… :
PS5, Line 1716: 	struct vlr_subscr **fsub =
(void*)&target->filter_data[LOG_FLT_VLR_SUBSCR];
"(foo*)" should be "(foo *)"

File src/libvlr/vlr_access_req_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/63048c43_313cbec8?us… :
PS5, Line 111: 	return par->result? gsm48_reject_value_name(par->result) :
"PASSED";
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c2d32d19_22177dcf?us… :
PS5, Line 415: 	} else {
else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/332a5631_95ac8845?us… :
PS5, Line 421: 		} else {
else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/62899804_53a8e029?us… :
PS5, Line 496: 		result = *(enum vlr_ciph_result_cause*)data;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2cfe38da_40a3a249?us… :
PS5, Line 791: 		.in_event_mask = ,
space prohibited before that ',' (ctx:WxE)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/74a505c9_54320281?us… :
PS5, Line 798: 		.in_event_mask = ,
space prohibited before that ',' (ctx:WxE)

File src/libvlr/vlr_auth_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/208027ac_caa3de45?us… :
PS5, Line 199: 			 res_len, (res_len == vec->res_len)? "valid" :
"INVALID on UTRAN");
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/8edb144e_4ea66591?us… :
PS5, Line 216: 	} else {
else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/94cd8a6d_0470a524?us… :
PS5, Line 543: 			strncpy(vsub->imsi, mi_string, sizeof(vsub->imsi));
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

File src/libvlr/vlr_lu_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/69a877d1_07b64548?us… :
PS5, Line 160: 	return (struct vlr_subscr*)fi->priv;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/52930bda_8f244ebd?us… :
PS5, Line 272: 	return (struct vlr_subscr*)fi->priv;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/89bc25ba_40fc87cf?us… :
PS5, Line 667: 	return (struct lu_compl_vlr_priv*)fi->priv;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/07824013_dbc8e70b?us… :
PS5, Line 1282: 		result = *(enum vlr_ciph_result_cause*)data;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/371f4d2b_4ede774f?us… :
PS5, Line 1404: 			cause = *(uint8_t*)data;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/7af5295b_f2f6825e?us… :
PS5, Line 1436: 			cause = *(uint8_t*)data;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/845150d6_28bdb5c9?us… :
PS5, Line 1643: 	return (struct lu_fsm_priv*)fi->priv;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/37c09fa5_24febf87?us… :
PS5, Line 1691: 		strncpy(lfp->imsi, imsi, sizeof(lfp->imsi)-1);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

File src/libvlr/vlr_sgs.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/0ba28c27_0cf666d9?us… :
PS5, Line 324: }
void function return statements are not generally useful

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d
Gerrit-Change-Number: 39560
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Comment-Date: Thu, 20 Feb 2025 14:43:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

2025

2024

2023

2022

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2