Attention is currently required from: jolly.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email )
Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/a16f6572_4bd42192 PS3, Line 17: playload Did you perhaps mean "payload"?
Patchset:
PS3: Aside from typos/grammar, I would give a CR+2 on the code itself at this point.
File src/osmo-bts-trx/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/63b99f1d_eed0cec1 PS3, Line 541: with This extraneous use of "with" here is ungrammatical. Simply removing the extra "with" will produce correct English grammar.
File src/osmo-bts-trx/sched_lchan_tchh.c:
https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/16a07373_c32e788d PS3, Line 456: with Same as above,