Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email )
Change subject: IuUP: Allow Initialization with set rem IP address and unset rem port
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/890ed34b_b58b214d
PS4, Line 7: rem
(i'd rather write out "remote" and
abbreviate "Init" and "addr")
Done
Patchset:
PS4:
Ok, I see, and agree with this. […]
I/we already
invested time into separating them. No need to spend more time now joining them, let's
leave it as is (I agree it would be arguable whether 1 or 2 is better).
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/fcdb22ec_e5acf916
PS4, Line 842: ASs
Ack
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/4141065f_d4203f9e
PS4, Line 843: MDCX
Ack
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Idd833997abce46886e9664505b2776fa5dadc8db
Gerrit-Change-Number: 35176
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Dec 2023 12:50:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment