Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33216 )
Change subject: osmo_sccp_simple_client_on_ss7_id(): Fail to start a client on an ASP explicitly configured as sctp server ......................................................................
Patch Set 2:
(1 comment)
File src/sccp_user.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/33216/comment/e415036e_5c891767 PS1, Line 633: if (default_local_ip) we could simply move the line 652 "asp->cfg.is_server = false;" in here and support both SCTP-role client and server in osmo_sccp_simple_client_on_ss7_id() in case where the ASP was explicitly configured.
pro: potentially supporting SCTP-role server in osmo-bsc/osmo-msc/osmo-hnbgw cons: confusing, since the function is about creating a client but instead a server is created (which may be fine if user explicitly configured it as such...)