Change in osmo-ttcn3-hacks[master]: MGCP_Test: reject empty fmtp strings

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31204 ) Change subject: MGCP_Test: reject empty fmtp strings ...................................................................... MGCP_Test: reject empty fmtp strings When setting up an RTP flow the fmtp string is checked using isvalue(), however this does not guard against empty fmtp strings. Rejecting empty strings is especially useful in situations where the caller wants to signal using "" that no fmtp string is present. Change-Id: I2641a52a3b271681f4f2e424c34be12e125092d6 Related: OS#5688 --- M mgw/MGCP_Test.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/31204/1 diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 6f25b20..362af4e 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -361,7 +361,7 @@ var SDP_attribute_list attributes; attributes := { valueof(ts_SDP_rtpmap(flow.pt, flow.codec)), valueof(ts_SDP_ptime(20)) }; - if (isvalue(flow.fmtp)) { + if (isvalue(flow.fmtp) and flow.fmtp != "") { attributes := attributes & { valueof(ts_SDP_fmtp(flow.pt, flow.fmtp)) }; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2641a52a3b271681f4f2e424c34be12e125092d6 Gerrit-Change-Number: 31204 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange