24 Aug
2023
24 Aug
'23
1:59 p.m.
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34190 )
Change subject: pcuif_proto: add confirmation flag to struct gsm_pcu_if_pch ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1: Same as I said on the other patch: I'm not liking this approach. Keep the BTS/BSC decoding the message type to know what to do with it, and let the "confirm" variable be simply a bool on whether the BSC answers to the PCU when it schedules/transmits it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34190
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia202862aafc1f0cb6601574ef61eb9155de11f04
Gerrit-Change-Number: 34190
Gerrit-PatchSet: 1
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 24 Aug 2023 13:59:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment