Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35791?usp=email )
Change subject: abis_nm: fix -Wunused-but-set-variable (bug) ......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/abis_nm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/35791/comment/01f49303_e8492658 PS2, Line 2168: const uint8_t *attr, int attr_len)
My point is that perhaps that check should be done by whoever does "oh->length - sizeof(*foh)", and […]
Is this really important who does this check? Feel free to submit improvements and/or take over this patch. I really don't see a good reason to spend too much time here, sorry. All I wanted to do is fixing a compilation warning, so that I could build osmo-bsc with `CC=clang` and `-Werror=all`. And fixed an actual bug while doing so.