Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28725 )
Change subject: Introduce APDU/TPDU trace decoder ......................................................................
Patch Set 1:
(2 comments)
File pySim/gsmtap.py:
https://gerrit.osmocom.org/c/pysim/+/28725/comment/8960a263_adf7d995 PS1, Line 153: Int8ub
Well, the check in the code allows us to be more flexible, I think it's one of those situation where […]
One advantage of using Const is that the parser will fail early with a clean error message, and not somewhere in the middle with less obvious reason like ShortRead. The version check below is done after parsing, so it only works if the bytestream was parsed without exceptions. I any case, this is not critical, you can keep this unchanged.
File pySim/ts_31_102.py:
https://gerrit.osmocom.org/c/pysim/+/28725/comment/5e0495d8_671c6d30 PS1, Line 303: # 3gPP TS 31.102 Section 7.5.2.1
why is it unrelated? That DataObject is referenced in the tracer: […]
Ah, indeed. Nevermind.