24 Jan
2023
24 Jan
'23
11:20 a.m.
Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31025 )
Change subject: Introduce tundev API
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS12:
I'm sorry to be having comments again... but I don't really understand why
adding/setting/removing addresses etc. is constrainted to tun-devices. We have the same
task for other net-devices, such as for example the GTP devices.
So IMHO, there should be a generic API to perform those operations on any type of netdev
(either by ifindex or name). Whether or not the tundev code then adds another
convenienece layer on top is a separate question.
The netns related code is als not really specifc to tun-devices, is it? Same applies to
gtp kernel devices or hdlc net-devices, right?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31025
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3463271666df1e85746fb7b06ec45a17024b8c53
Gerrit-Change-Number: 31025
Gerrit-PatchSet: 12
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 24 Jan 2023 10:20:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment