Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099 )
Change subject: rlcmac: Initial implementation of UL TBF assignment and scheduler
......................................................................
Patch Set 16:
(2 comments)
File src/rlcmac/tbf_ul_ass_fsm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099/comment/60e51b73_88e4f3b9
PS16, Line 53: [GPRS_RLCMAC_TBF_UL_ASS_ST_COMPL] = { },
(could just omit unset ones)
All of them are
unset. I'm just preparing all the boilerplate structures so that adding stuff
iteratively later is easier.
File src/rlcmac/tbf_ul_fsm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099/comment/865763d1_f2738066
PS16, Line 207:
(trailing blank line)
This is actually needed
otherwise linter fails.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/31099
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I420c57a9d0b63f9c2805a7c2ae8ce85532a48eef
Gerrit-Change-Number: 31099
Gerrit-PatchSet: 16
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Feb 2023 09:44:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment