[S] Change in libosmo-netif[master]: coverity CID#216829

Attention is currently required from: fixeria, neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37992?usp=email ) Change subject: coverity CID#216829 ...................................................................... Patch Set 4: Code-Review-1 (1 comment) File src/rtp.c: https://gerrit.osmocom.org/c/libosmo-netif/+/37992/comment/41da13dd_65f566c… : PS4, Line 151: if (payload_len < 0) { This is no longer possible according to checks above. payload_len is asserted to be >=0 when assigned: payload_len = msg->len - csrc_len; Because msg->len is asserted to be >= csrc_len. So please drop this check. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I30beeac45ff2d8c08905986af9fabfda071ddc5b Gerrit-Change-Number: 37992 Gerrit-PatchSet: 4 Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 09 Sep 2024 10:37:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes