Attention is currently required from: fixeria, neels.
Patch set 4:Code-Review -1
View Change
1 comment:
File src/rtp.c:
Patch Set #4, Line 151: if (payload_len < 0) {
This is no longer possible according to checks above.
payload_len is asserted to be >=0 when assigned:
payload_len = msg->len - csrc_len;
Because msg->len is asserted to be >= csrc_len.
So please drop this check.
To view, visit change 37992. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I30beeac45ff2d8c08905986af9fabfda071ddc5b
Gerrit-Change-Number: 37992
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Sep 2024 10:37:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes