fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42345?usp=email )
Change subject: s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null ......................................................................
s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null
After deactivate, conn_track still holds the now-dead reference. A second call (which can happen if any test explicitly calls this before f_ConnHdlr_s1ap_disconnect()) will attempt to deactivate an already-inactive default, which is a TTCN-3 runtime error.
Change-Id: I0b71b543fc7c4e87a86381cc3be23728e75cb59b Fixes: adc942a94 ("s1gw: track eNB connection, fail immediately on loss") --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified
diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 3decbcf..298a983 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -113,6 +113,7 @@ function f_ConnHdlr_conn_track_disable() runs on ConnHdlr { if (conn_track != null) { deactivate(conn_track); + conn_track := null; } }